Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing types to include description, raw for edit and create for the CI/CD Variables API #3542

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Fixing types to include description, raw for edit and create for the CI/CD Variables API #3542

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c5b99a8
Updating types
jdalrymple Feb 19, 2024
a3007ad
Updating raw type
jdalrymple Feb 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/core/src/resources/GroupVariables.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import type { BaseResourceOptions } from '@gitbeaker/requester-utils';
import { ResourceVariables } from '../templates';
import type { VariableSchema, VariableType } from '../templates/ResourceVariables';
import type { VariableFilter, VariableSchema, VariableType } from '../templates/ResourceVariables';
import type {
GitlabAPIResponse,
PaginationRequestOptions,
Expand All @@ -24,6 +24,8 @@ export interface GroupVariables<C extends boolean = false> extends ResourceVaria
protected?: boolean;
masked?: boolean;
environmentScope?: string;
description?: string;
raw?: string;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't "raw" boolean?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup! typo there. I fixed it up

} & Sudo &
ShowExpanded<E>,
): Promise<GitlabAPIResponse<VariableSchema, C, E, void>>;
Expand All @@ -37,6 +39,9 @@ export interface GroupVariables<C extends boolean = false> extends ResourceVaria
protected?: boolean;
masked?: boolean;
environmentScope?: string;
description?: string;
raw?: string;
filter: VariableFilter;
} & Sudo &
ShowExpanded<E>,
): Promise<GitlabAPIResponse<VariableSchema, C, E, void>>;
Expand Down
2 changes: 2 additions & 0 deletions packages/core/src/resources/ProjectVariables.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ export interface ProjectVariables<C extends boolean = false> extends ResourceVar
protected?: boolean;
masked?: boolean;
environmentScope?: string;
description?: string;
raw?: string;
} & Sudo &
ShowExpanded<E>,
): Promise<GitlabAPIResponse<ProjectVariableSchema, C, E, void>>;
Expand Down
4 changes: 4 additions & 0 deletions packages/core/src/templates/ResourceVariables.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@ export class ResourceVariables<C extends boolean> extends BaseResource<C> {
protected?: boolean;
masked?: boolean;
environmentScope?: string;
description?: string;
raw?: string;
} & Sudo &
ShowExpanded<E>,
): Promise<GitlabAPIResponse<VariableSchema, C, E, void>> {
Expand All @@ -60,6 +62,8 @@ export class ResourceVariables<C extends boolean> extends BaseResource<C> {
masked?: boolean;
environmentScope?: string;
filter: VariableFilter;
description?: string;
raw?: string;
} & Sudo &
ShowExpanded<E>,
): Promise<GitlabAPIResponse<VariableSchema, C, E, void>> {
Expand Down