Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap box-shadows with actual borders #154

Closed
wants to merge 1 commit into from
Closed

Conversation

robert-ryu7
Copy link
Collaborator

No description provided.

@vercel
Copy link

vercel bot commented Nov 16, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
98css ✅ Ready (Inspect) Visit Preview Nov 16, 2022 at 8:12AM (UTC)

@jdan
Copy link
Owner

jdan commented Nov 16, 2022 via email

@robert-ryu7
Copy link
Collaborator Author

Hi @jdan,

You mentioned previously that you prefer consistency (as do I). After giving it some thought I chose to use border image technique for all borders.

border-image uses actual CSS border which allows us to properly position scrollbars inside of an element (i did some comparisons using Win98 VM and scrollbars should be next to border and not over it). The only alternative solution that I know is to use 2 elements, one for overflow and other for border which might be ok but feels too cumbersome.

However, this makes theming a bit more difficult (but not impossible) since you won't be able to simply modify some color variables.

Anyway, if that's too much feel free to close this PR, don't want to go against any project rules. :)

@juanigaray
Copy link
Collaborator

I'm gonna close this PR as stale as a housekeeping measure. Please feel free to start a discussion in the discussions or issues sections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants