Fixed mutating content type from RelatedPart to MultiPart #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #194
I tried to write a test, but I can't find a way to check the
Content-Typeheader content of the outgoing email. It appears to not be included in the headers on sent_emails.Basically, mail-tracker was changing the
Content-Typeheader fromContent-Type: multipart/related;...toContent-Type: multipart/alternative;...for ALL RelatedPart messages. This likely impacts MixedPart too.I also fixed the previously-broken test for RelatedPart messages that was blocking PR #190
This was caused by c9a3379 only half-fixing the issue mentioned in #172. That commit added support for those two types of message contents as inputs, but isn't properly handling them as outputs.