Handle.inTransaction: improve exception when isolation restore fails

Fixes #2343
jdbi · May 4, 2023 · 0babcb4 · 0babcb4
1 parent 9c4fa9c
commit 0babcb4
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 5 deletions.
diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md
@@ -1,4 +1,5 @@
 # Unreleased
+  - Handle.inTransaction: improve exception thrown when restoring transaction isolation #2343
 
 # 3.38.2
   - spring5 JdbiUtil: fix thread safety #2341

diff --git a/core/src/main/java/org/jdbi/v3/core/Handle.java b/core/src/main/java/org/jdbi/v3/core/Handle.java
@@ -761,15 +761,22 @@ public <R, X extends Exception> R inTransaction(TransactionIsolationLevel level,
             return callback.withHandle(this);
         }
 
-        TransactionIsolationLevel currentLevel = getTransactionIsolationLevel();
-        try {
-            setTransactionIsolationLevel(level);
+        try (SetTransactionIsolation isolation = new SetTransactionIsolation(level)) {
             return transactionHandler.inTransaction(this, level, callback);
-        } finally {
-            setTransactionIsolationLevel(currentLevel);
         }
     }
 
+    class SetTransactionIsolation implements AutoCloseable {
+        private final TransactionIsolationLevel prevLevel;
+        SetTransactionIsolation(TransactionIsolationLevel setLevel) {
+            prevLevel = getTransactionIsolationLevel();
+            setTransactionIsolationLevel(setLevel);
+        }
+        @Override
+        public void close() {
+            setTransactionIsolationLevel(prevLevel);
+        }
+    }
     /**
      * Executes <code>callback</code> in a transaction.
      * <p>