Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: @RegisterKotlinMappers cannot be applied to interface #1971

Closed
usulkies opened this issue Dec 18, 2021 · 1 comment
Closed

Regression: @RegisterKotlinMappers cannot be applied to interface #1971

usulkies opened this issue Dec 18, 2021 · 1 comment

Comments

@usulkies
Copy link
Contributor

Using the declarative style with Dao required an interface.
Since the merge of PR #1930 - the RegisterKotlinMappers annotation cannot be applied to interfaces, since AnnotationTarget.TYPE does not include interfaces.
Annotating a Dao interface with this annotation is giving a compilation error:
This annotation is not applicable to target 'interface'

Seems like there's no test for this anywhere.

usulkies pushed a commit to usulkies/jdbi that referenced this issue Dec 19, 2021
usulkies pushed a commit to usulkies/jdbi that referenced this issue Dec 19, 2021
usulkies pushed a commit to usulkies/jdbi that referenced this issue Dec 19, 2021
usulkies pushed a commit to usulkies/jdbi that referenced this issue Dec 19, 2021
usulkies pushed a commit to usulkies/jdbi that referenced this issue Dec 19, 2021
usulkies pushed a commit to usulkies/jdbi that referenced this issue Dec 19, 2021
usulkies pushed a commit to usulkies/jdbi that referenced this issue Dec 19, 2021
Add a test
hgschmie pushed a commit that referenced this issue Dec 20, 2021
Use `CLASS` instead of `TYPE`, thus allowing these annotations to be present
on interfaces as well.

Fix issue #1971
hgschmie pushed a commit to hgschmie/jdbi that referenced this issue Dec 20, 2021
Use `CLASS` instead of `TYPE`, thus allowing these annotations to be present
on interfaces as well.

Fix issue jdbi#1971
hgschmie added a commit that referenced this issue Dec 20, 2021
Use `CLASS` instead of `TYPE`, thus allowing these annotations to be present
on interfaces as well.

Fix issue #1971

Co-authored-by: Uziel Sulkies <uziel@next-insurance.com>
@hgschmie
Copy link
Contributor

Fixed by cba804c, will be in next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants