-
-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support non-uniform batch entries #2110
Conversation
@hgschmie @stevenschlansker Seems like CI failed due unrelated reason. |
As all of the mappers deal with mapping data onto beans (which they use the setters for), they should also prefer the annotations found on the setter over the annotations on the getter. This PR also splits the very unwieldy and confusing BeanMapperTest into three separate tests, one focusing on general bean mapper properties, one for the PropagateNullable tests and one for Nested tests.
LGTM is dead, long live sonarcloud
05a4708
to
1441827
Compare
@hgschmie Updated this PR to be a general fix for the issues. Benchmarks (done on MacBook M1 Pro, 16G RAM): master:
This PR:
This PR without support for non-uniform batch entries (just the refactoring):
This PR, Postgres 14.5
This PR, Postgres 14.5, 200000 batch
My comments/thoughts:
|
1441827
to
dd58e2e
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Closing, still tracked in #2390. |
Closes #2114 #2110 #2078 #1968