VavrOptionMapper always uses ColumnMapper

[martyn0ff]

I've got an issue where VavrOptionMapper is not recognizing my existing ConstructorMapper for Foo.

org.jdbi.v3.core.mapper.NoSuchMapperException: No mapper for type class com.acme.Foo nested in Option
	at org.jdbi.v3.vavr.VavrOptionMapper.lambda$map$2(VavrOptionMapper.java:54)
	at java.base/java.util.Optional.orElseThrow(Optional.java:403)
	at org.jdbi.v3.vavr.VavrOptionMapper.map(VavrOptionMapper.java:54)
	at org.jdbi.v3.vavr.VavrOptionMapper.map(VavrOptionMapper.java:30)
	at org.jdbi.v3.core.mapper.SingleColumnMapper.lambda$new$0(SingleColumnMapper.java:41)
	at org.jdbi.v3.core.mapper.SingleColumnMapper.map(SingleColumnMapper.java:55)
	at org.jdbi.v3.core.result.internal.ResultSetResultIterator.next(ResultSetResultIterator.java:83)
	at org.jdbi.v3.core.result.ResultIterable.findOne(ResultIterable.java:198)

Turns out that this mapper assumes that the mapping should always be done by the means of ColumnMapper:

jdbi/vavr/src/main/java/org/jdbi/v3/vavr/VavrOptionMapper.java

Line 53 in 6456b97

final ColumnMapper<?> mapper = ctx.findColumnMapperFor(nestedType)

I believe that it should instead use a call to findMapperFor(GenericType) instead. For the time being this is easily fixable by using:

...
.mapTo(Foo.class)
.map(Option::of)
...

instead of

...
.mapTo(new GenericType<Option<Foo>>() {})
...

[hgschmie]

Hi @martyn0ff,

Thank you for filing an issue with Jdbi. This is a shortcoming of Jdbi as we do not currently have a row factory for vavr Option. This will be supported in the next release.

[hgschmie]

fixed in 3.43.0