Map long
and Long
arguments to BIGINT
#1902
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SQL type
INTEGER
often (always?) maps to integer types which are only 32 bits (4 bytes) long whileBIGINT
maps to integer types which are 64 bits (8 bytes) long.Considering this, mapping the Java types
long
andLong
to the SQL typeBIGINT
instead ofINTEGER
seems to make more sense.This is also consistent with the handling of
OptionalLong
in Jdbi:jdbi/core/src/main/java/org/jdbi/v3/core/argument/OptionalArgumentFactory.java
Lines 38 to 44 in ee22bb8
FWIW, this is motivated by a bug we discovered in CockroachDB when sending
NULL
values in a prepared statement which were sent asNULL::INT4
by Jdbi 3.20.1 instead ofNULL::INT8
for a column declared asINT8
:cockroachdb/cockroach#67605