Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DefineStatementLexer: improve backslash escape in quotes handling #2034

Merged
merged 2 commits into from May 26, 2022
Merged

DefineStatementLexer: improve backslash escape in quotes handling #2034

merged 2 commits into from May 26, 2022

Conversation

stevenschlansker
Copy link
Member

Fixes #1906

@stevenschlansker stevenschlansker requested a review from a team May 23, 2022 00:17
@stevenschlansker stevenschlansker mentioned this pull request May 23, 2022
Open
hgschmie
hgschmie approved these changes May 25, 2022
View reviewed changes
Copy link
Contributor

@hgschmie hgschmie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@hgschmie hgschmie merged commit 9e135ef into master May 26, 2022
@hgschmie hgschmie deleted the attr-parse-1906 branch May 26, 2022 16:20
@tmwoodruff tmwoodruff mentioned this pull request Aug 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hgschmie hgschmie hgschmie approved these changes

Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DefinedAttributeTemplateEngine parsing bug
2 participants
@stevenschlansker @hgschmie