Implement @RegisterCollector
#2357
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @TheRealRyGuy, Thank you for opening a PR with the Jdbi project. This seems a useful addition to our code base. As you pointed out, it would be good to have some tests (and also add some documentation). I will see if I can address this later this week. |
|
Kudos, SonarCloud Quality Gate passed!
|
|
|
||
| try { | ||
| Type type = null; //resultant type | ||
| for(Type t : registerCollector.value().getGenericInterfaces()) { |
There was a problem hiding this comment.
This looks like it could be something along the lines of GenericTypes.findGenericParameter(registerCollector.value(), Collector.class).orElseThrow(...)
There was a problem hiding this comment.
This calls Class#getGenericSuperclass instead of Class#getGenericInterfaces, not applicable as far as I know
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an annotation call to
JdbiCollectors#registerCollector(Type, Collector), allowing for QoL complex collectors as an alternative to making aCollectorFactoryfor use in interface DAOs.This could probably use some tests though