Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OnDemandExtensions: flatten stack a bit by inlining Unchecked #2440

Merged
merged 2 commits into from
Jul 14, 2023
Merged

OnDemandExtensions: flatten stack a bit by inlining Unchecked #2440

merged 2 commits into from
Jul 14, 2023

Commits on Jul 14, 2023

  1. OnDemandExtensions: flatten stack a bit by inlining Unchecked 

    We call Unchecked three times, and this ends up adding a number of stack frames
in the debugger or profiler any time you are looking at an ondemand sqlobject

This fights back just a little bit against ever-deepening stack traces,
and makes the logic easier to read too without the distracting Unchecked signatures in the middle
    @stevenschlansker
    stevenschlansker committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    928bb89 View commit details
    Browse the repository at this point in the history

  2. OnDemandExtensions.createProxy: Replace streams usage with simpler fl… 

    …at code
    @stevenschlansker
    stevenschlansker committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    d8ba280 View commit details
    Browse the repository at this point in the history