Ensure that the connection is always closed #2458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, we check if a connection is closed before closing it. Also, if a plugin fails to customize a Handle, the connection can leak However, this isn't good enough: even if the server closed the connection, we might have borrowed this from a pool, which needs to know we've returned it. Connection.close is specified to no-op if called more than once, so it's safe to just do it regardless. Fixes jdbi#2446
If the c'tor of a handle throws an exception, ensure that the underlying connection is closed as the caller will not have a chance to do so with try-with-resources This fixes the cause of jdbi#2446
hgschmie
force-pushed
the
fix-issue-2446
branch
from
7ea7ada
to
ffb9026
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
stevenschlansker
approved these changes
Aug 9, 2023
|
@kristoffSC, do you want to verify this proposed change fixes the connection leak for you? |
@hgschmie @stevenschlansker Is there any estimate date for new release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even if the init code in Jdbi or Handle fails, ensure that we don't leak connections.
Fixes #2446