Squashes checkstyle warnings #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To reduce noise.
|
Thanks for the fixup here. I'll merge this one in, but be advised that in general we are trying to keep cosmetic / stylistic fixups to the master branch to a minimum -- they end up causing large merge conflicts with our ongoing work on the |
stevenschlansker
added a commit
that referenced
this pull request
Dec 10, 2015
Squashes checkstyle warnings
|
Is it worth considering having the build fail if the check style fails? I've found that's a pretty effective way to avoid style cleanup commits like this one. |
|
Absolutely! I believe we have it enabled on the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.