Spring Jdbi repositories #2528
Spring Jdbi repositories #2528
Conversation
- add @EnableJdbiRepositories and @JdbiRepository annotations - add jdbi repository scanner and jdbi repository bean factory - proxy created extensions for spring transaction support - (bug fix) close handler when spring transaction is closed
|
Hi @xfredk! Thank you for your PR to the Jdbi project! I triggered the CI scripts and I will review in a bit. |
- fixed codestyle issues
- fixed codestyle issues
|
Kudos, SonarCloud Quality Gate passed!
|
|
De code analysis detected duplication of classes, but I do not know how to solve this problem. (Apparantely spring aop, a transitive dependency of spring context, copied some aopalliance classes into their jar) |
| Class clazz = ClassUtils.resolveClassName(className, null); | ||
|
|
||
| Map<String, Object> attributes = getAnnotationAttributes(JdbiRepository.class, annotationMetadata); | ||
| String jdbiQualifier = (String) attributes.get("jdbiQualifier"); |
There was a problem hiding this comment.
It's too bad you cannot use the annotation type itself here, like anno.jdbiQualifier(), but I guess this is how spring does this?
There was a problem hiding this comment.
I will check whether I can get it working (easily) by accessing the annotation directly. If so, I will create a new PR for it
| return Proxy.getInvocationHandler(target) | ||
| .invoke(target, method, args); | ||
| } else { | ||
| return MethodHandles.lookup().unreflect(method) |
There was a problem hiding this comment.
It is expensive to lookup the method handle every time you invoke the method, but it's probably ok to fix that later when it shows up as an actual performance bottleneck.
There was a problem hiding this comment.
I concur, it is possible to have an initialized object to do this, but the code will end up to be more complex while this code is already complex.
|
Yes, apparently spring-aop copied the aopalliance classes into their jar. That's annoying. |
this conflicts with spring-aop, which is coming in from #2528 we don't need these annotations in the docs either way.
|
@xfredk , it would be nice to add a little bit about this new feature into the docs if you have time. |
I wrote some code that scans for sql-object interfaces annotated with @JdbiRepository. These interfaces can be automatically detected by spring and used for autowiring in spring applications. These beans work seamlessly with spring transactions.
Points of notice:
I considered making a separate project but thought it was close enough to put it in the spring5 project