Make trailing semicolons in scripts configurable #2559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out that MySQL and Oracle simply have differing ideas on what a statement in a script should be. Oracle needs the trailing semicolons, MySQL throws syntax errors (when using the rewriteBatchedStatements=true setting, otherwise it reports a much saner "cannot issue select statements with update" type of error message. Added a switch that retains the default behavior but can be flipped to allow the error case described in jdbi#2554 to work. Reported by @IrinaTerlizhenko, thank you for this!
hgschmie
force-pushed
the
trailing-semicolon-switch
branch
from
b5dde71
to
2b1941d
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
stevenschlansker
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out that MySQL and Oracle simply have differing ideas on what a
statement in a script should be. Oracle needs the trailing semicolons,
MySQL throws syntax errors (when using the
rewriteBatchedStatements=true setting, otherwise it reports a much
saner "cannot issue select statements with update" type of error
message.
Added a switch that retains the default behavior but can be flipped
to allow the error case described in #2554 to work.
Reported by @IrinaTerlizhenko, thank you for this!