Update testcontainers and derby #2612
Conversation
hgschmie
force-pushed
the
versions-fix
branch
4 times, most recently
from
cb7f867
to
288708f
Compare
tc 1.19.4 contains the mysql fix for mysql 8.3.x derby 1.16 runs on JDK 17+ only
Use the `all` variant which shadows all dependencies into the driver.
hgschmie
force-pushed
the
versions-fix
branch
from
288708f
to
174a17b
Compare
|
| mysql-version: [ "mysql:latest" ] | ||
| # 1.18.3 does not work with mysql:latest (8.3.x). | ||
| include: | ||
| - testcontainer-version: 1.18.3 |
There was a problem hiding this comment.
Why do we keep testing against old, buggy versions of the library?
It is nice to be able to leave bugs in the past at some point.
There was a problem hiding this comment.
tc 1.18 is still the "previous minor". These tests exist mainly to ensure that when we adopt a new version of a library, we do not accidentally break users that are stuck on that version because e.g. their test framework requires it. Gives a somewhat smoother path to adoption.
We leave that version behind as soon as tc 1.20 is released.
|
it's the same BTW with derby. We could upgrade to 1.17 and just run the test when Java 21 is used. Right now, we run the test when 17+ is used (and stick with 1.16) because we support compiling the codebase with 17 and 21. Once we drop 17 for compilation, we can upgrade derby. I also resolved the dependabot issue, we are not actually using the LDAP piece that was in the CVE. |
tc 1.19.4 contains the mysql fix for mysql 8.3.x
derby 1.16 runs on JDK 17+ only