Introduce japicmp for API diffing #2616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hgschmie
commented
Jan 28, 2024
hgschmie
commented
- Update to basepom 58
- Introduce japicmp for API diffing
|
Resolves #2590 |
create a report for API compatibility for every build.
|
spannm
approved these changes
Jan 31, 2024
There was a problem hiding this comment.
I checked out the PR and tried to test but cannot get past unit test failures due to "Could not download artifact for Zonky Postgres 15" in core
Other than that LGTM. It will be interesting to see how this changes work on this project. Hopefully it won't be too intrusive...
|
Is that a general download failure? What error do you see? |
|
Hi @hgschmie, this occurred behind a network proxy and with a Nexus artifact manager in between in the office today. Most probably this can be ignored ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.