Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi nf support #47

Merged
merged 26 commits into from
Jul 27, 2023
Merged

multi nf support #47

merged 26 commits into from
Jul 27, 2023

Conversation

jddarby
Copy link
Owner

@jddarby jddarby commented Jul 13, 2023


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@sunnycarter
Copy link
Collaborator

It's quite hard to review this without looking at example output of a build, and it strikes me that in our tests we might want example output, like vnfdgen used to have. I couldn't quickly test myself, for want of an input file pointing to real NFs.

Interested in your thoughts here.

I cannot easily see (without having some example output), how you have solved the problem of different NFs having conflicting deploy Parameters. I think what you've done is put them each in their own section of the config group schema, and then in the config mappings, you reference that particular NF.

Better docstrings on many of the functions would help review here. As would example output.

@sunnycarter
Copy link
Collaborator

azdev style aosm returns quite a lot of errors (9.76 out of 10). Because as a team we haven't sorted out dev processes or told each other about them, I don't know if this is worse, acceptable or what. I'd like to sort this out.

development.md says:

  • to run azdev style aosm but not what we want the output to be
  • to run adev linter but not what we want the output to be
  • to run mypy as follows:
    mypy . --ignore-missing-imports --no-namespace-packages --exclude "azext_aosm/vendored_sdks/*"
    This doesn't work for me
    I did add a pyproject.toml for running mypy, I think this needs changing to
cd src/aosm
mypy .

(Sorry I thought I had documented this before)

@jamiedparsons jamiedparsons merged commit b192027 into add-aosm-extension Jul 27, 2023
@jamiedparsons jamiedparsons deleted the jdd/multi-nf-support branch July 27, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants