Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linting #55

Merged
merged 2 commits into from
Aug 1, 2023
Merged

Fix linting #55

merged 2 commits into from
Aug 1, 2023

Conversation

jamiedparsons
Copy link
Collaborator

Fix so that the latest version of flake8 works and azdev style aosm passes.

@sunnycarter
Copy link
Collaborator

Looks fine, thank you for doing this. Fixes it for me. The only worry is that that .flake8 file is for all extensions in AZ CLI, not just our aosm one. But, it's buggered so I agree we should fix. They can ask us in review if they don't want the change.

Don't understand why others haven't hit this first, but also, don't understand where the flake8 dependency comes from - whether it comes from the azdev setup --cli /home/developer/code/azure-cli --repo . or when you add the extension, or just when you do pip install azdev. sigh. As you say, poetry would be much nicer.

In the pipelines, the flake8 version installed is 3.5.0 (see azure-pipelines.yml) - I think this would still work with that? So go for it, they can complain at review time.

@jamiedparsons jamiedparsons merged commit 1ebce61 into add-aosm-extension Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants