Set state for all parameters #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this fix @hdoupe. |
jdebacker
pushed a commit
that referenced
this pull request
May 21, 2021
Update PUF expected results
jdebacker
pushed a commit
that referenced
this pull request
Mar 2, 2022
Update round trip reform tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the failing test, but I'm not 100% sure why this is causing a problem with ParamTools 0.16.1. I'll continue looking into this.
A bunch of smaller updates are done while doing the main parameter value update. The operators for converting parameter values to NumPy arrays and then extending them throughout the budget window are turned off so that we aren't doing extra work after each of these smaller updates.
https://github.com/PSLmodels/Tax-Calculator/blob/565158d4385901be0ef5c5f9332a5e567587e9e5/taxcalc/parameters.py#L190-L194
https://github.com/PSLmodels/Tax-Calculator/blob/565158d4385901be0ef5c5f9332a5e567587e9e5/taxcalc/parameters.py#L334
Then once they are done, the operators are turned back on and the parameters that need to be converted to NumPy arrays or extended through the budget window are updated.
https://github.com/PSLmodels/Tax-Calculator/blob/565158d4385901be0ef5c5f9332a5e567587e9e5/taxcalc/parameters.py#L424-L437
However, it seems like a lot of the parameter values (including
UBI_ecrt) were not converted to NumPy arrays. If I just reset the values for all parameters, then the test passes. I'm going to do some more digging to figure out why 0.16.0 is causing this behavior. In the meantime, this should get all unit tests passing again.@jdebacker @Peter-Metz