Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add asseets/svg/ back to dist in published package #58

Open
ThatOneCalculator opened this issue Dec 5, 2023 · 5 comments
Open

Add asseets/svg/ back to dist in published package #58

ThatOneCalculator opened this issue Dec 5, 2023 · 5 comments

Comments

@ThatOneCalculator
Copy link

Misskey and Firefish rely on dist/svg being in the NPM package, as it was there in previous versions.

image

@jdecked
Copy link
Owner

jdecked commented Dec 5, 2023

@ThatOneCalculator This should probably be filed against @discordapp/twemoji since that's the dist directory being referenced (and Twemoji hasn't included SVGs in dist for a long long time), but since our goal is to get Discord off of their fork where this is necessary anyway – could you please tell me how Misskey and Firefish rely on dist/svg so I can provide some alternatives? Thanks!

@ThatOneCalculator
Copy link
Author

Yeah, both projects relied on a very outdated twemoji version then switched to Discord's fork when it released. Essentially, we have a /twemoji/*svg route that'll serve the corresponding svg from the dist in node_modules.

@jdecked
Copy link
Owner

jdecked commented Dec 6, 2023

Essentially, we have a /twemoji/*svg route that'll serve the corresponding svg from the dist in node_modules.

This is not supported. Discord's fork will also soon stop supporting this. Please tell me your use case so I can help you find an alternative that is supported.

@ThatOneCalculator
Copy link
Author

The use case is that we want to serve Twemoji assets that are hosted on our server(s).

@setchy
Copy link

setchy commented Aug 9, 2024

Sharing a related use-case we have for gitify-app/gitify.

We are looking to introduce twemoji parsing to increase our cross-platform compatibility, but ideally would want to source the SVGs locally since we have some offline modes that aren't compatible with using an online CDN.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants