Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ✨ unicode 15 #43

Closed

Conversation

ThatOneCalculator
Copy link

@ThatOneCalculator ThatOneCalculator commented Jun 23, 2023

Uses the new Unicode 15 emojis directly from Twitter, closes #8

Conflicts with #24 #35 #25 #23 #17 #15 #13 , but I wouldn't mind if some of the custom designed replaced the vanilla Twemoji ones. This PR is to get Unicode 15 emojis up and running.

1fae8 1fa77 1fa75 1fa76 1facf
1face 1fabf 1fabd 1fabc 1fabb
1fadb 1fada 1faad 1faae 1fa88
1fa87 1faaf 1f6dc 1faf8 1faf7
1faf8-1f3fb 1faf8-1f3fc 1faf8-1f3fd 1faf8-1f3fe 1faf8-1f3ff
1faf7-1f3fb 1faf7-1f3fc 1faf7-1f3fd 1faf7-1f3fe 1faf7-1f3ff

@ThatOneCalculator ThatOneCalculator marked this pull request as draft June 23, 2023 04:41
@ThatOneCalculator
Copy link
Author

Drafting until I update Twemoji parser

@ThatOneCalculator
Copy link
Author

ThatOneCalculator commented Jun 23, 2023

@jdecked , do you know how I can get twemoji-parser to build the emoji regex? I ran

# installed python 3.8.17
yarn install
 ./src/scala/scripts/generate.sh  

modified src/scala/pants.toml with pants_version = "1.26.0"

but ended up with the error

21:56:34 00:36         [cache] 
                     No cached artifacts for 1 target.
                     Invalidated 1 target. 
21:56:34 00:36         [coursier]
21:57:00 01:02         [cache] 
                     No cached artifacts for 1 target.
                     Invalidated 1 target. 
21:57:00 01:02         [coursier]
                       ==== stdout ====
                       
                       ==== stderr ====
                       java.lang.ExceptionInInitializerError
                        at org.pantsbuild.tools.jar.JarBuilder$JarWriter.copy(JarBuilder.java:1275)
                        at org.pantsbuild.tools.jar.JarBuilder.copyJarFiles(JarBuilder.java:1069)
                        at org.pantsbuild.tools.jar.JarBuilder.write(JarBuilder.java:1024)
                        at org.pantsbuild.tools.jar.Main.doRun(Main.java:401)
                        at org.pantsbuild.tools.jar.Main.run(Main.java:367)
                        at org.pantsbuild.tools.jar.Main.main(Main.java:481)
                        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
                        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
                        at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
                        at java.base/java.lang.reflect.Method.invoke(Method.java:568)
                        at com.martiansoftware.nailgun.NGSession.run(NGSession.java:280)
                       Caused by: java.lang.reflect.InaccessibleObjectException: Unable to make field protected volatile java.io.InputStream java.io.FilterInputStream.in accessible: module java.base does not "opens java.io" to unnamed module @3ff6018f
                        at java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:354)
                        at java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:297)
                        at java.base/java.lang.reflect.Field.checkCanSetAccessible(Field.java:178)
                        at java.base/java.lang.reflect.Field.setAccessible(Field.java:172)
                        at org.pantsbuild.tools.jar.JarEntryCopier$FieldReader.create(JarEntryCopier.java:34)
                        at org.pantsbuild.tools.jar.JarEntryCopier.<clinit>(JarEntryCopier.java:94)
                        ... 11 more
                       
                   zinc[zinc-only](config/src/main/scala/com/twitter/emoji/config:config) failed: jar-tool failed in 43.372817277908325
FAILURE: Compilation failure: ExecutionFailure('Failed jobs: zinc[zinc-only](config/src/main/scala/com/twitter/emoji/config:config)')


               Waiting for background workers to finish.
21:57:06 01:08   [complete]
               FAILURE
               ```

@ThatOneCalculator
Copy link
Author

ThatOneCalculator commented Jun 23, 2023

On this note, I'm unsure if updating twemoji-parser is even needed? It's only used once, in the build script:

      // add the RegExp in the right place
      .replace('re = /twemoji/', `re = ${regex.toString()}`)

"add the RegExp in the right place" is very vauge. What is the "right place"? Is the build script even needed anymore?

@Felting
Copy link

Felting commented Jun 27, 2023

Have you managed to fix the twemoji-parser?

@Felting Felting mentioned this pull request Jun 27, 2023
@ThatOneCalculator
Copy link
Author

Not yet. I haven't managed to get the build script to run without failing.

@ThatOneCalculator
Copy link
Author

On that note, I'd really appreciate some guidance or feedback from @jdecked if they're not too busy.

@jdecked
Copy link
Owner

jdecked commented Jun 27, 2023

On that note, I'd really appreciate some guidance or feedback from @jdecked if they're not too busy.

Please see #8 (comment).

@ThatOneCalculator
Copy link
Author

Got it. I was concerned that may be the case, so I'll close this. Thank you for your work on maintaining this project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unicode 15
3 participants