New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ✨ unicode 15 #43
feat: ✨ unicode 15 #43
Conversation
Drafting until I update Twemoji parser |
@jdecked , do you know how I can get twemoji-parser to build the emoji regex? I ran # installed python 3.8.17
yarn install
./src/scala/scripts/generate.sh modified but ended up with the error 21:56:34 00:36 [cache]
No cached artifacts for 1 target.
Invalidated 1 target.
21:56:34 00:36 [coursier]
21:57:00 01:02 [cache]
No cached artifacts for 1 target.
Invalidated 1 target.
21:57:00 01:02 [coursier]
==== stdout ====
==== stderr ====
java.lang.ExceptionInInitializerError
at org.pantsbuild.tools.jar.JarBuilder$JarWriter.copy(JarBuilder.java:1275)
at org.pantsbuild.tools.jar.JarBuilder.copyJarFiles(JarBuilder.java:1069)
at org.pantsbuild.tools.jar.JarBuilder.write(JarBuilder.java:1024)
at org.pantsbuild.tools.jar.Main.doRun(Main.java:401)
at org.pantsbuild.tools.jar.Main.run(Main.java:367)
at org.pantsbuild.tools.jar.Main.main(Main.java:481)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at com.martiansoftware.nailgun.NGSession.run(NGSession.java:280)
Caused by: java.lang.reflect.InaccessibleObjectException: Unable to make field protected volatile java.io.InputStream java.io.FilterInputStream.in accessible: module java.base does not "opens java.io" to unnamed module @3ff6018f
at java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:354)
at java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:297)
at java.base/java.lang.reflect.Field.checkCanSetAccessible(Field.java:178)
at java.base/java.lang.reflect.Field.setAccessible(Field.java:172)
at org.pantsbuild.tools.jar.JarEntryCopier$FieldReader.create(JarEntryCopier.java:34)
at org.pantsbuild.tools.jar.JarEntryCopier.<clinit>(JarEntryCopier.java:94)
... 11 more
zinc[zinc-only](config/src/main/scala/com/twitter/emoji/config:config) failed: jar-tool failed in 43.372817277908325
FAILURE: Compilation failure: ExecutionFailure('Failed jobs: zinc[zinc-only](config/src/main/scala/com/twitter/emoji/config:config)')
Waiting for background workers to finish.
21:57:06 01:08 [complete]
FAILURE
``` |
On this note, I'm unsure if updating // add the RegExp in the right place
.replace('re = /twemoji/', `re = ${regex.toString()}`) "add the RegExp in the right place" is very vauge. What is the "right place"? Is the build script even needed anymore? |
Have you managed to fix the twemoji-parser? |
Not yet. I haven't managed to get the build script to run without failing. |
On that note, I'd really appreciate some guidance or feedback from @jdecked if they're not too busy. |
Please see #8 (comment). |
Got it. I was concerned that may be the case, so I'll close this. Thank you for your work on maintaining this project! |
Uses the new Unicode 15 emojis directly from Twitter, closes #8
Conflicts with #24 #35 #25 #23 #17 #15 #13 , but I wouldn't mind if some of the custom designed replaced the vanilla Twemoji ones. This PR is to get Unicode 15 emojis up and running.