Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use XcodeprojHelper for finding Xcode projects #27

Merged
merged 1 commit into from May 13, 2019
Merged

Use XcodeprojHelper for finding Xcode projects #27

merged 1 commit into from May 13, 2019

Conversation

ghost
Copy link

@ghost ghost commented Feb 21, 2019

Resolves #25.

This simply adopts the changes made to commit_version_bump by #14000.

Let me know what you think! If you agree with the change, it would be great if this could be merged.

The settings-bundle plugin is broken since Fastlane 2.113.0.

We're currently using our own fork with this patch applied.

@ghost
Copy link
Author

ghost commented May 13, 2019

@jdee Are you still accepting contributions for this repo? If not, it might be worthwhile to deprecate the project as it seems like it doesn't work with the current version of fastlane.

@jdee
Copy link
Owner

jdee commented May 13, 2019

@daniel-mohemian Sorry for the delay. I'll review and get a release out, hopefully later today.

In the long term, I think I'd prefer to contribute this plugin to the main Fastlane repo, or at least to the Fastlane GitHub org, or to another existing org on GitHub, or create an org for the purpose, so that others can also maintain this plugin. I'm glad people are using it. Let me review the matter with the Fastlane peeps, though I welcome any community suggestions on a long-term home for this plugin.

@jdee jdee merged commit 2e7df3e into jdee:master May 13, 2019
@jdee
Copy link
Owner

jdee commented May 13, 2019

Released in 1.3.2.

@ghost ghost deleted the bugfix/25 branch May 15, 2019 11:25
@ghost
Copy link
Author

ghost commented May 15, 2019

Thanks, @jdee, and no worries. That's great news. It enables us to switch back to your upstream repo.

As for your plans for the future, I think integrating into the Fastlane repo/org sounds like a reasonable way forward. Let us know how it goes! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ignore_cocoapods_path has been removed from Fastlane
2 participants