Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a cancellable convenience method #88

Closed
saturnism opened this issue Nov 22, 2016 · 3 comments
Closed

Add a cancellable convenience method #88

saturnism opened this issue Nov 22, 2016 · 3 comments
Assignees
Milestone

Comments

@saturnism
Copy link
Member

Add a convenience method to DeferredManager to easily create CancelablePromise. To avoid conflicts in semantics w/ the existing when methods, propose to add cancelable method:

p = dm.cancelable(() -> { ... });
p.cancel();
@saturnism saturnism added this to the 1.2.5 milestone Nov 22, 2016
@saturnism saturnism self-assigned this Nov 22, 2016
@saturnism
Copy link
Member Author

/cc @aalmiray

@saturnism
Copy link
Member Author

Maybe this should be part of 1.3 since it will introduce a new signature to the interface. On the other hand, it won't break anyone who didn't implement their own DeferredMananger.

@saturnism saturnism modified the milestones: 1.3, 1.2.5 Dec 13, 2016
@saturnism
Copy link
Member Author

This is superseded by #126

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

1 participant