-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JDeferred 2.0 - Roadmap #115
Comments
@aalmiray I feel some of these things were done in the last 2.x branch merge. I updated the list, PTAL. |
@aalmiray the exceptions handlers needs to be registered with every promise, specifically in AbstractPromise in the triggerXYZ() methods. If we pass the reference in a constructor, that'll mean every subclass will have to get it and will change a lot of signatures. Moreover, promises that aren't created by DeferredManager won't register. Alternatively, we can have a static global class that holds the exception handler and every promise instances would just refer to that. This would work w/ all promises even those created outside of DeferredManager. wdyt? |
The problem with a static global location is thread-safety and synchronization. We could "cheat" by using |
on the other hand, associating it to every deferred object might be too much for a crosscutting concern though. let's discuss more at baselone 😄 |
@aalmiray regarding the convenience method, the best I have so far is Promises.resolve(...) and Promises.reject(...). I can't think of anything else at the moment. Should we still include it? They can also be part of DeferredManager, e.g., dm.resolve(...) |
I think so, as it's the only way to support resolved/rejected promises with |
Do you feel it should be part of |
My gut feeling tells me it should be part of |
i think we are almost done :D |
Nice to have, possibly 2.1:
Promises
Add a cancellable convenience method #88The text was updated successfully, but these errors were encountered: