fix: add bias and drive mode options to switches - now tested and updated #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: bump version to 1.1.0
|
Hi, this and more is fixed and updated in the latest version tag 1.1.0. Is there anything else you added? I can't test since I don't have such a relay, but both bias and drive are options in switch in current main branch. I guess we worked in parallel. |
|
Hello, yes there's no AS_IS for example, so removed it Can you maybe edit your invert logic stuff and merge ? |
|
sry, it's all in the latest version anyway, so no use merging this anymore. fwiw from my gpiod in homeassistant: >>> import gpiod
>>> print(gpiod.line.Bias._member_names_)
['AS_IS', 'UNKNOWN', 'DISABLED', 'PULL_UP', 'PULL_DOWN']
>>> help(gpiod.line.Bias) # for more info |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, Ive tested this weekend, my fork run on my home setup, flawlessly :)
I also added documentation + renamed some variables to stick to gpiod naming conventions
please merge asap, cuz your main branch might be broken !