"Callback was already called" bug

[ctaschereau]

At this line in the set function, we can see that the callback is in fact inside the try statement. This has the side effect that if some code throws immediately after calling the set function, we will fall inside the catch statement of the set function and then have an "Callback was already called" error.

connect-mongo/src/lib/MongoStore.ts

Lines 399 to 404 in 3e27376

	this.emit('set', sid)
	callback(null)
	} catch (error) {
	callback(error)
	}
	})()

example code :

session.save(() => {
    throw new Error('some random error happened... (ex : uncaught)');
});

I have tested just moving the "callback" outside of the try/catch statement (and adding a return after the callback that is inside the catch) and the behaviour appears to be correct. I'll try and find the time to submit a proper pull request this weekend.

[mingchuno]

4.6.0 released