Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add @types/ dev dependencies for tsc. fixes #340 #341

Merged
merged 4 commits into from Oct 30, 2019
Merged

fix: add @types/ dev dependencies for tsc. fixes #340 #341

merged 4 commits into from Oct 30, 2019

Conversation

guyellis
Copy link
Contributor

I tested this by:

@coveralls
Copy link

coveralls commented Oct 30, 2019

Coverage Status

Coverage remained the same at 81.649% when pulling 286d1e7 on guyellis:master into cbc95be on jdesboeufs:master.

@mingchuno
Copy link
Collaborator

@guyellis should you run yarn install so that the lock file got updated?

@guyellis
Copy link
Contributor Author

@mingchuno - yes - good call - I was wondering why the npm lockfile had been excluded in gitignore and now I see the project is using yarn. I've updated it and pushed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants