Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade mongodb to 5.0.0 #466

Merged
merged 1 commit into from
Mar 14, 2023
Merged

Conversation

MarkoCen
Copy link
Contributor

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
  • MongoDB 5.0 has been released for a while, this PR introduces a breaking change to upgrade the peer dependency mongodb to 5.0.0
  • What is the current behavior? (You can also link to an open issue here)

#465

  • What is the new behavior (if this is a feature change)?

I considered the changes in this PR as breaking changes since the MongoClient typing in mongodb@5 is not compatible with the one in mongodb@4, so the upgrade will break the interface.

  • Other information:

  • Checklist:

  • Added test cases

  • Updated changelog

@jgmedialtd
Copy link

@jdesboeufs - please could you take a look at this, Mongo Atlas is updating users to v5 in March so this will become more important

@neil-hardlight
Copy link

neil-hardlight commented Mar 9, 2023

@jdesboeufs - please could you take a look at this, Mongo Atlas is updating users to v5 in March so this will become more important

Note that there's a difference between the database version and the driver version. Mongo driver 3.7+ is compatable with MongoDB v5.

https://www.mongodb.com/docs/drivers/node/current/compatibility/

Having said this - I'd also like to see connect-mongo get this update asap so that I can upgrade to the latest version of mongoose/mongodb.

@LucyMaber
Copy link

can you meage this plz

@jgmedialtd
Copy link

I've emailed the maintainer and hopefully will get some attention soon.

@mingchuno
Copy link
Collaborator

@MarkoCen May I ask why the change in the old CHANGELOG? Am I missing something? In general, this PR looks good. Let me take a look and will merge soon.

@MarkoCenCircle
Copy link

I think it was auto formatted by IDE, I can revert those changes

@mingchuno
Copy link
Collaborator

@MarkoCen Cool. Could you please help revert it and only add your change?

@MarkoCen
Copy link
Contributor Author

@mingchuno reverted changes to the old changelog items

@mingchuno mingchuno merged commit ae1bae1 into jdesboeufs:master Mar 14, 2023
@mingchuno
Copy link
Collaborator

mingchuno commented Mar 14, 2023

https://www.npmjs.com/package/connect-mongo?activeTab=versions

5.0.0 released to npm

@MarkoCen MarkoCen deleted the mongodb-5.0 branch June 24, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants