Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(imagepreview): 无法在预期情景正确关闭图片的异常 #2421

Merged
merged 3 commits into from
Jul 10, 2024

Conversation

Alex-huxiyang
Copy link
Collaborator

@Alex-huxiyang Alex-huxiyang commented Jul 8, 2024

把事件放到正确的位置

  • 日常 bug 修复
  • 站点、文档改进
  • 演示代码改进

Summary by CodeRabbit

  • 新功能

    • ImagePreview 组件新增 closeOnContentClick 属性,用户点击内容时预览图会关闭。
  • 改进

    • TaroVideoImage 组件中添加了 closeOnImg 点击事件处理,优化了交互体验。
    • closeOnImg 函数现在接受 any 类型参数,增强了事件处理的灵活性。

Copy link

coderabbitai bot commented Jul 8, 2024

Walkthrough

组件库中的 ImagePreview 组件进行了多个增强,包括添加新属性 closeOnContentClick 和在多个事件处理程序中引入 closeOnImg 函数,从而改善了组件的交互行为。

Changes

文件路径 变更摘要
src/packages/imagepreview/demos/h5/demo1.tsx
src/packages/imagepreview/demos/taro/demo1.tsx
ImagePreview 组件中添加了 closeOnContentClick 属性。
src/packages/imagepreview/imagepreview.taro.tsx
src/packages/imagepreview/imagepreview.tsx
引入了 closeOnImg 函数,调整了 TaroVideoImage 组件的 onClick 事件处理。

Poem

在代码的世界,一只小兔舞蹈,
closeOnImgcloseOnContentClick 新绿草上笑。
组件更新,提升交互,
用户喜笑,体验如此奇妙。
代码清晰,未来更好,
与你分享这一刻的骄傲。 🎉


Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between d2abbcd and 1311f2d.

Files selected for processing (1)
  • src/packages/imagepreview/imagepreview.taro.tsx (4 hunks)
Files skipped from review as they are similar to previous changes (1)
  • src/packages/imagepreview/imagepreview.taro.tsx

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.01%. Comparing base (9337a24) to head (1311f2d).

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #2421   +/-   ##
=======================================
  Coverage   86.01%   86.01%           
=======================================
  Files         217      217           
  Lines       22855    22862    +7     
  Branches     2545     2545           
=======================================
+ Hits        19658    19665    +7     
  Misses       3192     3192           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Alex-huxiyang Alex-huxiyang changed the title fix(imagepreview): 无法在预期情景正确关闭图片的相关异常 fix(imagepreview): 无法在预期情景正确关闭图片的异常 Jul 8, 2024
@@ -20,6 +20,7 @@ const Demo1 = () => {
return (
<>
<ImagePreview
closeOnContentClick
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

考虑下 不改demo的情况下,怎么实现~
改demo 意味着用户都得改~~~

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

之前的版本仅在微信小程序下表现异常,原因主要是Image组件在微信端表现不一致导致。调整并精简了Image组件写法使各端一致的表现。对方反馈在京东小程序业务下已经解决了问题。

@pull-request-size pull-request-size bot added size/M and removed size/S labels Jul 9, 2024
@xiaoyatong xiaoyatong merged commit cbf6765 into jdf2e:next Jul 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants