Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tabs滚动条兼容火狐浏览器 #2431

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

JoanneXu6677
Copy link
Contributor

@JoanneXu6677 JoanneXu6677 commented Jul 10, 2024

🤔 这个变动的性质是?

  • 新特性提交
  • [v ] 日常 bug 修复
  • 站点、文档改进
  • 演示代码改进
  • [ v] 组件样式/交互改进
  • TypeScript 定义更新
  • 包体积优化
  • 性能优化
  • 功能增强
  • 国际化改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他改动(是关于什么的改动?)

🔗 相关 Issue

#2427

💡 需求背景和解决方案

给nut-tabs-titles加上兼容火狐浏览器隐藏滚动条属性

 /* Firefox */
scrollbar-width: none;

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • [ v] 文档已补充或无须补充
  • [ v] 代码演示已提供或无须提供
  • [ v] TypeScript 定义已补充或无须补充
  • [ v] fork仓库代码是否为最新避免文件冲突
  • [ v] Files changed 没有 package.json lock 等无关文件

Summary by CodeRabbit

  • 样式
    • 更新标签样式以隐藏滚动条。

Copy link

coderabbitai bot commented Jul 10, 2024

Walkthrough

这次变更主要是为了隐藏选项卡组件中的滚动条。通过向 tabs.scss 文件中添加 scrollbar-width: none; 样式,从而实现这一效果。

Changes

文件路径 变更摘要
src/packages/tabs/tabs.scss 在样式中添加 scrollbar-width: none; 以隐藏滚动条

Poem

选项卡中悄悄改,
滚动条影儿不再来。
无痕滑动多流畅,
用户体验乐开怀。 🌟


Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 9337a24 and bcbdba6.

Files selected for processing (1)
  • src/packages/tabs/tabs.scss (1 hunks)
Files skipped from review due to trivial changes (1)
  • src/packages/tabs/tabs.scss

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.98%. Comparing base (9337a24) to head (bcbdba6).
Report is 2 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2431      +/-   ##
==========================================
- Coverage   86.01%   85.98%   -0.03%     
==========================================
  Files         217      217              
  Lines       22855    22855              
  Branches     2545     2542       -3     
==========================================
- Hits        19658    19652       -6     
- Misses       3192     3198       +6     
  Partials        5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oasis-cloud oasis-cloud merged commit 9ca55b3 into jdf2e:next Jul 10, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants