Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(formItem): validateTrigger无法正确触发校验 #2433

Merged
merged 2 commits into from
Jul 12, 2024

Conversation

Alex-huxiyang
Copy link
Collaborator

@Alex-huxiyang Alex-huxiyang commented Jul 10, 2024

经排查,导致每次onChange都触发的原因是setFieldsValue中进行了validate校验

  • 日常 bug 修复

Summary by CodeRabbit

  • 修复
    • 删除了表单验证方法在构造函数中的调用,提升表单性能。

Copy link

coderabbitai bot commented Jul 10, 2024

Walkthrough

这些变更主要涉及 FormStore 类中方法调用的删除。在 src/packages/form/useform.taro.ts 文件中,validateFields() 方法调用从构造函数中移除。在 src/packages/form/useform.ts 文件中,this.validateFields() 方法调用从 updateForm 方法中移除。这些改动简化了表单的初始化和更新流程。

Changes

文件 变更摘要
src/packages/form/useform.taro.ts FormStore 类中,从构造函数中移除了 validateFields() 方法调用
src/packages/form/useform.ts FormStore 类中,从 updateForm 方法中移除了 this.validateFields() 方法调用

Poem

在代码的森林里,兔子跳跃轻盈,
表单简化,流程愈加分明。
初始化轻松,更新也不再繁琐,
程序运行如风,开发者心欢喜。


Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 9ca55b3 and d68fa7a.

Files selected for processing (2)
  • src/packages/form/useform.taro.ts (1 hunks)
  • src/packages/form/useform.ts (1 hunks)
Files skipped from review due to trivial changes (2)
  • src/packages/form/useform.taro.ts
  • src/packages/form/useform.ts

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.01%. Comparing base (9ca55b3) to head (d68fa7a).

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2433      +/-   ##
==========================================
- Coverage   86.01%   86.01%   -0.01%     
==========================================
  Files         217      217              
  Lines       22863    22862       -1     
  Branches     2545     2545              
==========================================
- Hits        19665    19664       -1     
  Misses       3193     3193              
  Partials        5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oasis-cloud oasis-cloud merged commit b964b47 into jdf2e:next Jul 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants