Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No mpeg-dash or streams > 720p #230

Closed
anxdpanic opened this issue Jan 9, 2018 · 24 comments
Closed

No mpeg-dash or streams > 720p #230

anxdpanic opened this issue Jan 9, 2018 · 24 comments

Comments

@anxdpanic
Copy link
Collaborator

anxdpanic commented Jan 9, 2018

dashmpd url not returned by get_video_info for vods

get_video_info parameter 'el'

no longer working (Invalid Parameters):
'default'
'info'
'vevo'

working w/ no dashmpd url:
'leanback'
'embedded'
'detailpage'
'editpage'
'adunit'
'previewpage'
'profilepage'

@greystashh
Copy link

Can you say whether this can be fixed?

@anxdpanic
Copy link
Collaborator Author

anxdpanic commented Jan 9, 2018

Wish I could. The 'el' parameter values 'default', 'info', and 'vevo' now all return invalid where they worked previously. And the working ones, 'leanback', 'embedded', 'detailpage', 'editpage' are not returning the dash url. It's also not found via the watch?v= page.

@anxdpanic
Copy link
Collaborator Author

It looks like it is still returned for live content and for drm protected content.

@greystashh
Copy link

Live content was still working with dash. Can you give an example for DRM content?

@anxdpanic
Copy link
Collaborator Author

drm content (Purchases/rentals) is staged but isn't ready for the add-on yet, inputstream.adaptive updates are required first.

https://github.com/anxdpanic/plugin.video.youtube/releases/tag/purchases-test
https://github.com/anxdpanic/plugin.video.youtube/tree/purchases

@greystashh
Copy link

Can't you adapt this for the the vods?

@anxdpanic
Copy link
Collaborator Author

The request for vod/live/drm are the same, only now for vod there is no dash url being returned with any of the 'el' parameters that I'm aware of.

@Schtek
Copy link
Contributor

Schtek commented Jan 11, 2018

Is there any reason why it would not be possible to create our own mpd file and feed that to inputstream.adaptive? After all it seams that most of the information is there, with the streams in adaptive_fmts.

@anxdpanic
Copy link
Collaborator Author

anxdpanic commented Jan 11, 2018

Not able to dump valid manifest and start playback from the local file. As far as I can tell this isn't an option. :\

Schtek added a commit to Schtek/plugin.video.youtube that referenced this issue Jan 11, 2018
@Schtek
Copy link
Contributor

Schtek commented Jan 11, 2018

I managed to generate a MPD file that worked on VLC 3.0.0 rc6. However, I lack the knowledge on how to test it in Kodi.

@anxdpanic
Copy link
Collaborator Author

https://github.com/Schtek/plugin.video.youtube/commits/mpd-file is the working generated file?
I can cherry pick and try in kodi.

@Schtek
Copy link
Contributor

Schtek commented Jan 11, 2018

Yes, I added some code in bottom of resources/lib/youtube_plugin/youtube/helper/video_info.py that genereates a MPD-file from the data in adaptive_fmts.

anxdpanic pushed a commit to anxdpanic/plugin.video.youtube-bak that referenced this issue Jan 11, 2018
@anxdpanic
Copy link
Collaborator Author

They are not working in Kodi, also confirmed they are working with 3.0.0 rc6 like you mentioned. https://github.com/anxdpanic/plugin.video.youtube/tree/generated_mpd

@Schtek
Copy link
Contributor

Schtek commented Jan 11, 2018

https://github.com/anxdpanic/plugin.video.youtube/tree/generated_mpd
That one works for me on kodi, to some degree. Seems that only a few of the streams are working.

I have reason to belive that it is only the stream first selected by inputstream.adaptive that works. So if the stream is switched early in the playback it does not work at all. But don't hold me on that one.

@anxdpanic
Copy link
Collaborator Author

anxdpanic commented Jan 11, 2018

Do you have an example of a video id that's working with in Kodi?

@Schtek
Copy link
Contributor

Schtek commented Jan 11, 2018

https://www.youtube.com/watch?v=sgIqRwvaBw4
Every video I have tried has worked, but most, like this one, start with no audio. This I can work around by toggling the audio stream in the settings.

Maybe it depends on inputstream adaptive settings.

@anxdpanic
Copy link
Collaborator Author

inputstream adaptive errors on loading the local file for me everytime. Do you happen to be testing videos under My Channel? Can you post a debug log?

@Schtek
Copy link
Contributor

Schtek commented Jan 11, 2018

kodi_part.log

Here is a log from when the playback starts.

I am testing videos from many different channels.

@anxdpanic
Copy link
Collaborator Author

anxdpanic commented Jan 11, 2018

Thanks. It's an issue with filesystems that use \'s

@greystashh
Copy link

Wouldnt that be possible for temporary workaround?

@anxdpanic
Copy link
Collaborator Author

Possibly, I've staged a basic proxy for hosting up the local mpd's to overcome the filesystem shortcoming.
https://github.com/anxdpanic/plugin.video.youtube/tree/generated_mpd

Issue now at least for me, all I can get is low quality with no audio.

@anxdpanic
Copy link
Collaborator Author

#235 generates the mpd, and serves it by proxy.

The audio and video issues were due to unsupported codecs. Allowing only 'video/mp4' and 'audio/mp4' resolved issues with quality and sound.

I have another issue to look at and then I will bump the alpha zip. The changes are in master now though if you'd like to try it.

Thanks again @Schtek 👍

@Schtek
Copy link
Contributor

Schtek commented Jan 12, 2018

It works great on my end now.
Thanks to you too for integrating it so soon!

@anxdpanic
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants