Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I integrated the layouting fix for iOS 4.2 #44

Closed
wants to merge 2 commits into from
Closed

I integrated the layouting fix for iOS 4.2 #44

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
efedaeb
Fixed iOS 4.2 layout issue
lippling Feb 2, 2012
d362cd3
Fixed memory management issue
lippling Feb 2, 2012
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion MBProgressHUD.m
View file
Open in desktop
Expand Up @@ -322,6 +322,7 @@ - (id)initWithFrame:(CGRect)frame {

#if !__has_feature(objc_arc)
- (void)dealloc {
[[NSNotificationCenter defaultCenter] removeObserver:self];
[indicator release];
[label release];
[detailsLabel release];
Expand All @@ -342,7 +343,8 @@ - (void)layoutSubviews {
CGRect frame = self.bounds;

// Compute HUD dimensions based on indicator size (add margin to HUD border)
CGRect indFrame = indicator.bounds;
CGRect indFrame = CGRectZero; // CGRect indFrame = indicator.bounds; <- This line caused issues on armv6 architecture / Release mode, with iOS SDK 5.0 and LLVM 3.0 compiler
indFrame.size = indicator.bounds.size;
self.width = indFrame.size.width + 2 * margin;
self.height = indFrame.size.height + 2 * margin;

Expand Down