add new property to judge HUD contentView space to HUD elements #460
Conversation
…lLabel, or custom views) margin will only determine the space between HUD edge to HUD contentView
There was a problem hiding this comment.
While I like the idea and it's more flexible than the previous implementation, it's a breaking change in behavior.
It would need to be written in a way where the insets would default to UIEdgeInsetsMake(margin, margin, margin, margin); and would only change if somebody sets them explicitly to keep compatibility with the current behavior.
Perhaps something we should rather do during a major release.
| @@ -232,11 +232,21 @@ NS_ASSUME_NONNULL_BEGIN | |||
| @property (assign, nonatomic) CGPoint offset UI_APPEARANCE_SELECTOR; | |||
|
|
|||
| /** | |||
| * The amount of space between the HUD edge and the HUD elements (labels, indicators or custom views). | |||
| * The amount of space between the HUD edge and the HUD contentView. | |||
| * This also represents the minimum bezel distance to the edge of the HUD view. | |||
There was a problem hiding this comment.
This also represents the minimum bezel distance to the edge of the HUD view.
Only this part seems to still hold. Not the first sentence.
|
|
||
| /** | ||
| * The amount of space between the HUD contentView and the HUD elements (labels, indicators or custom views). | ||
| * This also represents the minimum bezel distance to the edge of the HUD view. |
There was a problem hiding this comment.
Does it? Looks to me like this is still the margin?
| * This also represents the minimum bezel distance to the edge of the HUD view. | ||
| * Defaults to 20.f | ||
| */ | ||
| @property (assign, nonatomic) CGFloat margin UI_APPEARANCE_SELECTOR; | ||
| @property (assign, nonatomic) CGFloat margin; |
There was a problem hiding this comment.
Why remove UI_APPEARANCE_SELECTOR.
margin will only determine the space between HUD edge to HUD contentView