Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#7] Truncate journal and snapshot store #8

Merged
merged 1 commit into from Jul 13, 2015
Merged

[#7] Truncate journal and snapshot store #8

merged 1 commit into from Jul 13, 2015

Conversation

Unisay
Copy link
Contributor

@Unisay Unisay commented Jun 2, 2015

I think that solution with truncate method in the singleton object is simpler than sending a message.
Moreover - message approach wouldn't work with snapshot store since receive() is final and can't be overridden.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.35%) to 83.33% when pulling 6353cda on Unisay:master into d2b3892 on jdgoldie:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.35%) to 83.33% when pulling d864bfd on Unisay:master into d2b3892 on jdgoldie:master.

jdgoldie added a commit that referenced this pull request Jul 13, 2015
@jdgoldie
Merge pull request #8 from Unisay/master
28038b5 
[#7] Truncate journal and snapshot store
@jdgoldie jdgoldie merged commit 28038b5 into jdgoldie:master Jul 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Unisay @coveralls @jdgoldie