Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Swift 3 support into master #16

Closed
wants to merge 36 commits into from

Conversation

ikesyo
Copy link
Contributor

@ikesyo ikesyo commented Nov 8, 2016

It would be great if we get a new release which supports Swift 3. 😃

Ref: #14

For more info: <swiftlang/swift@9bee5d1>

Also, remove errant line break.
It only took until June…
…Layout.

Flattening the directory structure under Source qualifies a single library module, as we intend.

- Rename files of `ColorType` conformers to `Color · «Name».swift`.
- Rename `Wrap.swift` to `ColorWrap.swift`.
- Add directory `Tests/Unit` to qualify a test module for Swift Package Manager.
- In Xcode Project
	- Remove Color group. Add new references to moved source files.
	- Update reference locations for test source files.

For more info: [see `example/Sources`… block and following text.](https://github.com/apple/swift-package-manager/blob/4f3e70/Documentation/SourceLayouts.md)
No more `blob/master` GitHub links.
…ff9e4.

`Tests/Unit` directory added to qualify a test module for Swift Package Manager.

<jdhealy@5ff9e4b>
- Reduce to single test target, also configured with `jdhealy/FABConfig`.
- Reduce to single scheme.
- Support additional platforms of tvOS and watchOS and corresponding simulators.
- Set `CODE_SIGNING_REQUIRED` to `NO` (through `jdhealy/FABConfig`).
	- Remove configuration `CODE_SIGN_IDENTITY[sdk=iphoneos*] = "iPhone Developer"`.
	- Trust in Xcode 8+ automatic code signing defaults.
		- Code signing will usually still be required at the point of embedding PrettyColors in a code-signed bundle.
		- See <jdhealy/FABConfig#1> for more info.
For the commits which enable the additional platforms in Xcode, [see this comment][1].
[1]: jdhealy#12 (comment)
…ice, exclude watchOS.

Exclude watchOS based on no published XCTest framework for the platform.
…re descriptive workflow.

As of Xcode 8S162m, the XCTest framework is not published for watchOS or its simulator. <https://openradar.appspot.com/21760513> provides (some) additional information.
Squashes [the history from `pr/swift-2.3` branch][1], sans Xcode 7.3.1 matrix inclusions.

Credit to @ikesyo. Commit message amended by @jdhealy. See <jdhealy#13>.

[1]: https://github.com/jdhealy/PrettyColors/commits/pr/swift-2.3/.travis.yml
Remove extraneous whitespace.

Swift 3.0 conformance.

See: <swiftlang/swift@4c2dbe1>.
@ikesyo
Copy link
Contributor Author

ikesyo commented Dec 13, 2016

@jdhealy I'm sorry to bother you, but is there any news on a new Swift 3 compatible release? Looks like some works are done on your development branch.

@jdhealy
Copy link
Owner

jdhealy commented Dec 13, 2016

@ikesyo No, my apologies. I have some time scheduled away tomorrow to test on a local Linux machine, then tag and ship a release.

Appreciate the huge amount of swift3-prep that you've been doing on Carthage!

@mdiep
Copy link

mdiep commented Jan 27, 2017

bump

@jdhealy
Copy link
Owner

jdhealy commented Jan 31, 2017

5.0.0: Swift 3 · Support Swift Package Manager

https://github.com/jdhealy/PrettyColors/releases/tag/5.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants