Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time Seems off in logs #46

Closed
edshaw42 opened this issue Feb 16, 2023 · 5 comments
Closed

Time Seems off in logs #46

edshaw42 opened this issue Feb 16, 2023 · 5 comments
Labels
invalid This doesn't seem right

Comments

@edshaw42
Copy link

Description

image

I believe the times it says in the logs are incorrect because the UTC time and date are wrong for my flights.

To Reproduce

run script passing confirmation first last

Expected Behavior

Date/time to be correct

Version

No response

Additional context

No response

@edshaw42 edshaw42 added the bug Something isn't working label Feb 16, 2023
@jdholtz
Copy link
Owner

jdholtz commented Feb 16, 2023

If I’m getting this correct, your first flight time should be 8:15pm CT (Nashville TZ) on 2023-02-16 and your returning flight should be at 1:55pm (Orlando TZ) on 2023-02-20. Are both incorrect?

@jdholtz
Copy link
Owner

jdholtz commented Feb 22, 2023

Hey @edshaw42, did you ever verify if the times were accurate or not?

@babehboi
Copy link

I'm pretty sure it's probably right. Thank you for the script by the way. I tried it yesterday and works wonderfully!

That being said I was about to comment that the days were wrong until I noticed it said UTC. And did my own conversions to check up against it.

But I could be wrong :: shrugs ::

It seems like your script is pulling the appropriate time to which to check in via their system it wouldn't matter about timezones since you're using the UTC of the system that has polled the data?

Otherwise can't wait to see when you're able to do the price check. I've been trying this other script but haven't been successful in deploying just yet.

@jdholtz
Copy link
Owner

jdholtz commented Feb 22, 2023

Thank you for the script by the way. I tried it yesterday and works wonderfully!

Glad you are finding it useful!

It seems like your script is pulling the appropriate time to which to check in via their system it wouldn't matter about timezones since you're using the UTC of the system that has polled the data?

UTC is the easiest to use to ensure the time will always correct. Southwest gives the airport code and time of the flight. In this file, the matching TZ is retrieved from the code. Then, the time is converted from that TZ to UTC.

Otherwise can't wait to see when you're able to do the price check

I’ll definitely try to include that at some point, although it’ll take some time. I’m still not sure on whether to include it as a separate project that is integrated with this script or keep it in this project. Any comments and/or feedback on #38 would be appreciated!

@schmeed
Copy link

schmeed commented Feb 23, 2023

I’ll definitely try to include that at some point, although it’ll take some time. I’m still not sure on whether to include it as a separate project that is integrated with this script or keep it in this project. Any comments and/or feedback on #38 would be appreciated!

If I have vote, I would vote for a separate project. I think it could overly complicate the check-in script. It needs to remain lightweight and single purposed, IMO.

@jdholtz jdholtz added invalid This doesn't seem right and removed bug Something isn't working labels Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

4 participants