Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module imports inside class methods #4

Open
heilgeirr opened this issue Jul 27, 2018 · 1 comment · May be fixed by #62
Open

module imports inside class methods #4

heilgeirr opened this issue Jul 27, 2018 · 1 comment · May be fixed by #62
Assignees
@VeldinaElena

Comments

@heilgeirr
Copy link
Collaborator

not a good python practice.

example: JDI/web/selenium/elements/api_interact/get_element_module.py, GetElementModule.get_search_context.
@ZoiaOchikova
Copy link
Collaborator

The better way is to restructure arhitecture for the following classes: GetElementModule, Element, BaseElement.
The main problem is in GetElementModule.get_search_context method. Need to remove cyclic imports inside method. Remove non-OOP structures such as: isinstance(...), issubclass(...), type(element).

@VeldinaElena VeldinaElena self-assigned this May 27, 2021
@VeldinaElena VeldinaElena linked a pull request Jun 7, 2021 that will close this issue
Module imports inside class methods #62
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VeldinaElena VeldinaElena

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Module imports inside class methods jdi-testing/jdi-python
3 participants
@ZoiaOchikova @heilgeirr @VeldinaElena