issues_1189_1190: Fixed switching between locator types and validation icon #1202
Conversation
| @@ -1,22 +1,20 @@ | |||
| import React from "react"; | |||
| import { Spin, Tooltip } from "antd"; | |||
| import Icon from "@ant-design/icons"; | |||
| import CheckedEdited from "../assets/checked-edited.svg"; | |||
There was a problem hiding this comment.
please, delete svg file as well
| newValue.locator.customXpath = locator; | ||
| locatorType !== LocatorType.cssSelector | ||
| ? (newValue.locator.customXpath = locator) | ||
| : (newValue.locator.cssSelector = locator); |
There was a problem hiding this comment.
please, use if. ternary looks confusing here
There was a problem hiding this comment.
or you can write smth like following:
newValue.locator = locatorType !== LocatorType.cssSelector
? { ...newValue.locator, customXpath: locator }
: { ...newValue.locator, cssSelector: locator };
| const nodeSnapshot = document.evaluate(xPath, document, null, XPathResult.ORDERED_NODE_SNAPSHOT_TYPE, null); | ||
| const length = nodeSnapshot.snapshotLength; | ||
| const foundElement = nodeSnapshot.snapshotItem(0) as Element; | ||
| const foundElements = document.querySelectorAll(selector); |
There was a problem hiding this comment.
let's use querySelector, since there's no need in ...All
| value === locatorType ? form.setFieldValue("locator", locatorField) : form.setFieldValue("locator", ""); | ||
| } else { | ||
| form.setFieldValue("locator", getLocator(locator, value)); | ||
| } |
There was a problem hiding this comment.
there if's need to be refactored. for example, extract them to functions.
also, code will be less verbose if you write form.setFieldValue("locator", result) once in the end, and only calculate result value above
|
|
||
| const onFieldsChange = async (changedValues: any) => { | ||
| const [changedValue] = changedValues; | ||
| const isLocatorTypeChanged = changedValue?.name[0] === "locatorType"; |
There was a problem hiding this comment.
what is the type of changedValues? Is there always will be inly one value? Using index can be unstable for cases when there are more that one item in array
No description provided.