Task 1661: Fix Disable right click locator selection #1681
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
KateDronova
commented
Mar 17, 2024
KateDronova
commented
Iogsotot
requested changes
Mar 18, 2024
Comment on lines
-256
to
-258
| } else { | ||
| /** with "more button" used, active class is always converted **/ | ||
| toggleActiveClass(highlightTarget); |
There was a problem hiding this comment.
Возможно, связано с этим участком кода
потерялся функционал: при клике ПКМ на неактивный элемент он становится активным и открывается меню
было: 
теперь:
не работает + ошибка в консоли контент-скриптов
There was a problem hiding this comment.
Я этот функционал и убрала - в этом и была задача ведь: разделить функционалы ЛКМ и ПКМ - нет?
There was a problem hiding this comment.
да, ты права, спасибо, что указала. Тогда только ошибку из консоли убрать на клик и всё ок
…ssue_1661-disable-right-click-locator-selection
…tps://github.com/jdi-testing/jdn-ai into issue_1661-disable-right-click-locator-selection
KateDronova
deleted the
issue_1661-disable-right-click-locator-selection
branch
|
См. #1694 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.