Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task 1661: Fix Disable right click locator selection #1681

Closed

Conversation

KateDronova
Copy link
Contributor

Screenshot_2

@KateDronova KateDronova added the bug Something isn't working label Mar 17, 2024
@KateDronova KateDronova added this to the Release 3.16 milestone Mar 17, 2024
@KateDronova KateDronova self-assigned this Mar 17, 2024
@Iogsotot Iogsotot removed this from the Release 3.16 milestone Mar 18, 2024
Comment on lines -256 to -258
} else {
/** with "more button" used, active class is always converted **/
toggleActiveClass(highlightTarget);
Copy link
Contributor

@Iogsotot Iogsotot Mar 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Возможно, связано с этим участком кода
потерялся функционал: при клике ПКМ на неактивный элемент он становится активным и открывается меню
было: image

теперь:
не работает + ошибка в консоли контент-скриптов
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Я этот функционал и убрала - в этом и была задача ведь: разделить функционалы ЛКМ и ПКМ - нет?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

да, ты права, спасибо, что указала. Тогда только ошибку из консоли убрать на клик и всё ок

@KateDronova KateDronova deleted the issue_1661-disable-right-click-locator-selection branch March 29, 2024 08:34
@KateDronova
Copy link
Contributor Author

См. #1694

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants