Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error-field styling not visible #7

Closed
jdickey opened this issue Dec 23, 2015 · 1 comment
Closed

Error-field styling not visible #7

jdickey opened this issue Dec 23, 2015 · 1 comment
Assignees
Labels

Comments

@jdickey
Copy link
Owner

jdickey commented Dec 23, 2015

To demonstrate, fire up the app and click the "Add New Thing" button. Enter data for the fields, specifying an initial quantity of 0. When you hit the 'Submit' button, Rails wraps the invalid field (label and input control) in a div.field_with_errors (note the un-CSS-like underscores) element. Bootstrap knows nothing of this, apparently; it's incumbent upon us to define it.

This issue depends on both #5 (obviously) and #6.

@jdickey jdickey added the bug label Dec 23, 2015
@jdickey jdickey self-assigned this Dec 23, 2015
@jdickey jdickey added this to the Fabulous v0.9.1 milestone Dec 23, 2015
@jdickey
Copy link
Owner Author

jdickey commented Dec 23, 2015

Nathan Tempelman on StackOverflow has an apparently useful solution to this, though why he uses a vendor prefix for WebKit is not immediately clear. I'd also prefer to use SCSS variables for the literals in his example, but they'd both compile down to the same thing in the asset pipeline.

@jdickey jdickey mentioned this issue Dec 24, 2015
jdickey added a commit that referenced this issue Dec 28, 2015
Styling cleanup completed per Issues #5, #6, and #7.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant