Fix #12: don't rely on empty string to signify a resolved but unavail…

…able executable path
jdidion · Jun 14, 2017 · 782bf28 · 782bf28
1 parent 57cfa73
commit 782bf28
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -1,7 +1,8 @@
-v3.0.2 (dev)
-------------
+v3.0.2 (2017.06.14)
+-------------------
 * Forcing use of backports.typing for python < 3.6.
 * Added basic performance testing.
+* Fixed #12: xphyle not recognizing when system-level lzma not installed.
 
 v3.0.1 (2017.04.29)
 -------------------

diff --git a/xphyle/formats.py b/xphyle/formats.py
@@ -675,6 +675,7 @@ class SingleExeCompressionFormat(CompressionFormat): # pylint: disable=abstract-
     def __init__(self):
         self._executable_path = None
         self._executable_name = None
+        self._resolved = False
 
     @property
     def executable_path(self) -> PathLike:
@@ -707,13 +708,11 @@ def decompress_name(self) -> str:
         return self.executable_name
 
     def _resolve_executable(self) -> None:
-        if self._executable_path is None:
+        if not self._resolved:
             exe = EXECUTABLE_CACHE.resolve_exe(self.system_commands)
             if exe:
                 self._executable_path, self._executable_name = exe
-            else:
-                self._executable_path = self._executable_name = ''
-
+            self._resolved = True
 
 class GzipBase(SingleExeCompressionFormat):
     """Base class for gzip and bgzip files.