Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added special semantic coloring for consts, readonly properties, and enums. #81

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kronodeus
Copy link
Contributor

@kronodeus kronodeus commented Aug 23, 2023

This PR depends upon #80 because it requires semantic highlighting to be enabled.

The examples below demonstrate the changes to how constant/read-only tokens are colored. This is similar to how the modern built-in VS Code themes behave. Implementation taken from the Dark+ built-in theme. Colors taken from the original Gruvbox palette.

Before

Screenshot 2023-08-23 at 12 27 02 PM Screenshot 2023-08-23 at 12 35 02 PM

After

Screenshot 2023-08-23 at 12 26 37 PM Screenshot 2023-08-23 at 12 35 19 PM

@jdinhify
Copy link
Owner

@kronodeus looks like the change to overall semantics token in #83 affected how these look.

Could you please have a look again and see if you want to readjust 🙏

A suggestion is that try to use brighter colours to provide more contrast, the dark blue on dark background seems a bit lacking in contrast and make it somewhat hard to read as the result.

Bright colours for dark theme below

red2 fb4934
green2 b8bb26
yellow2 fabd2f
blue2 83a598
purple2 d3869b
aqua2 8ec07c
orange2 fe8019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants