Allow clicking list items #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I could not reproduce the issue @jdittrich mentioned on jdittrich#3. Tested on Chrome on a Mac, so I'm assuming this commit addresses what was mentioned on jdittrich#3. This commit also rename all occurrences of "cursor" I could find to "caret" ("cursor" is related to mouse, "caret" to keyboard. See README of https://github.com/redhog/ep_cursortrace); Also improved some tests and avoided errors when Etherpad instance has default pad text set on settings.json.
|
@jdittrich Can you test if this solution works for you? I could not reproduce the error you've mentioned on #3, so I don't know if this PR will address what you needed. |
…elected This avoids having double-calls to callbacks if any of the callbacks uses sendkeys. Also improved some tests and avoided errors when Etherpad instance has default pad text set on settings.json.
|
It does resolve the problem. It could have been due to an older etherpad version, too (which was current at the time of writing the bug) |
|
Awesome! #4 is on its way too -- we have it working on our plugin that extends ep_autocomp, only need to move the code to this plugin and test if everything is working properly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I could not reproduce the issue @jdittrich mentioned on #3. Tested on
Chrome on a Mac, so I'm assuming this commit addresses what was
mentioned on #3.
This commit also rename all occurrences of "cursor" I could find to
"caret" ("cursor" is related to mouse, "caret" to keyboard. See README
of https://github.com/redhog/ep_cursortrace);
Also improved some tests and avoided errors when Etherpad instance has
default pad text set on settings.json.