Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a cargo task which outputs a 30-60 second gif or webp version of the render #3

Open
carlsverre opened this issue Mar 8, 2021 · 2 comments
Open

Add a cargo task which outputs a 30-60 second gif or webp version of the render #3

carlsverre opened this issue Mar 8, 2021 · 2 comments

Comments

@carlsverre
Copy link
Collaborator

No description provided.

@carlsverre carlsverre mentioned this issue Mar 8, 2021
Open
@jdkaplan
Copy link
Owner

jdkaplan commented Mar 8, 2021

I had the same idea! I-have-no-idea-what-I'm-doing version in bc2a25c

@carlsverre
Copy link
Collaborator Author

Nice! Send a PR and I'll leave comments. At a high level it would be nice to:

@jdkaplan jdkaplan mentioned this issue Mar 11, 2021
Merged
jdkaplan added a commit that referenced this issue Mar 13, 2021
@jdkaplan
Stitch animation frames together (#5)
f2e66ac 
Compiling art is cool and all, but it'd be even cooler if we could share the video.  As a step toward #3, this adds a way to run the animation for a fixed number of frames and output those frames to PNGs.  There's also an `ffmpeg` recipe for stitching these together into a video.

Still TODO:
* Allow CLI args to set the animation time
* Stop relying on `ffmpeg` to pack the frames together.
@jdkaplan jdkaplan mentioned this issue Mar 22, 2021
Merged
jdkaplan added a commit that referenced this issue Mar 22, 2021
@jdkaplan
Use CLI args to create model (#6)
ccfdf71 
Continuing from #5 and on our way to #3, this threads the CLI args through to the model.  (What I was missing in that late-night PR was that we could parse the options _in_ the model function.)

This makes frame output a "mode": it only writes the frame PNGs if `--output-dir` is set.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@carlsverre @jdkaplan