Updates for Julia 0.7, dropping 0.6 support #48
Conversation
|
Now includes updates discussed at #47 (comment). |
|
@schmrlng should this be rebased and reconfigured to support |
|
Sure IIRC it's essentially ready to go code-wise (and I've been using it on 1.0 for a month or two with no issues), but stand by for some fluctuation on this PR while I try to get the CI updated/happy. |
|
CI passes (though Coverage might be broken at the moment), so I think this is ready to go. Documenter.jl best practices seem to be evolving at the moment; for future reference I used the approach described here for now: |
|
@huckl3b3rry87 since you initially authored the |
| warn("Message type '$typ' conflicts with Julia builtin, ", | ||
| "will be imported as '$(_jl_safe_name(typ,"Msg"))'") | ||
| @warn("Message type '$typ' conflicts with Julia builtin, ", | ||
| "will be imported as '$(_jl_safe_name(typ,"Msg"))'") |
There was a problem hiding this comment.
It looks like auto-concatenation of logging messages doesn't happen anymore and this ends up printing the substitution content verbatim in the resulting message. Can just use an extra call to string I suppose.
| warn("Use of type '$typestr' is deprecated in message definitions, ", | ||
| "use '$(lowercase(string(_ros_builtin_types[typestr])))' instead.") | ||
| @warn("Use of type '$typestr' is deprecated in message definitions, ", | ||
| "use '$(lowercase(string(_ros_builtin_types[typestr])))' instead.") |
There was a problem hiding this comment.
Will need the multi-arg logging fix as well.
|
@schmrlng much thanks for your patience and help in getting this done. |
Includes #47; see discussion there for a proposal on a double release (
RobotOSv0.6.3 including #47, i.e., the first commit here, and then this PR as v0.7.0).