Add shutdown method for Service object #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdlangs
reviewed
Dec 17, 2019
src/services.jl
Outdated
| Shut down the specified service. | ||
| """ | ||
| function shutdown(s::Service{ST}) where ST <: AbstractService | ||
| pycall(s.srv_obj["shutdown"], Nothing) |
There was a problem hiding this comment.
PyCall has deprecated this style of accessing functions, the preferred style is simply s.srv_obj.shutdown
There was a problem hiding this comment.
Thanks for your review! I fixed the style.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added shutdown method for service object. Without this, one has to restart a Julia session all the time when the callback function of a Service is modified, which is time-consuming because compilation will start over again.