Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure some typegen code to fix break in 1.5 #84

Merged
merged 5 commits into from Aug 18, 2020
Merged

Conversation

jdlangs
Copy link
Owner

@jdlangs jdlangs commented Aug 18, 2020

As reported in #82, the code that used hardcoded accessing into Expr objects broke in julia 1.5 due to the internals of the expressions being represented differently. This gets around it by avoiding accessing Expr internals at all, preferring to splice the generated expressions where they are needed.

This also modifies travis to run on ubuntu 18.04 and ROS melodic and bumps the version to 0.8.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 91.628% when pulling 769b7b1 on jl1.5fix into 4df0ab0 on master.

@jdlangs jdlangs merged commit 233a1c6 into master Aug 18, 2020
@jdlangs jdlangs deleted the jl1.5fix branch August 19, 2020 19:44
@jdlangs jdlangs mentioned this pull request Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants