Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Proxy trait for restructuring #15

Merged
merged 14 commits into from
Nov 30, 2023
Merged

feat: add Proxy trait for restructuring #15

merged 14 commits into from
Nov 30, 2023

Conversation

jdockerty
Copy link
Owner

@jdockerty jdockerty commented Nov 27, 2023

Introduces a Proxy trait to encompass common functionality, this splits the application into tcp.rs and http.rs which makes the structure much easier to follow.


This also includes #18 which reduces the RwLock contention by scoping it down to a minimum.

@jdockerty jdockerty self-assigned this Nov 27, 2023
@jdockerty jdockerty force-pushed the feat/proxy-trait branch 2 times, most recently from e083475 to ba8c305 Compare November 29, 2023 10:05
By creating this client in the wrong place it was creating a new Arc for each listener on a separate thread and drastically cut performance. Causing a bottleneck to around 25 req/s
@jdockerty jdockerty marked this pull request as ready for review November 29, 2023 21:59
@jdockerty jdockerty changed the title feat: add trait feat: add Proxy for restructuring Nov 29, 2023
@jdockerty jdockerty changed the title feat: add Proxy for restructuring feat: add Proxy trait for restructuring Nov 29, 2023
@jdockerty jdockerty merged commit d078563 into main Nov 30, 2023
1 check passed
@jdockerty jdockerty deleted the feat/proxy-trait branch November 30, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant